Skip to content

gh-100239: specialize BINARY_OP/SUBSCR for list-slice #132626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-100239: specialize BINARY_OP/SUBSCR for list-slice #132626

wants to merge 5 commits into from
+544 −346

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Apr 17, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 17, 2025
Open
@markshannon
Copy link
Member

markshannon commented Apr 17, 2025 •
edited
Loading

list_subscript/_PyList_Subscript is the general subscript function for lists. I think we want to use a more specialized function that only works for slices. i.e this code: https://github.com/python/cpython/blob/main/Objects/listobject.c#L3614-L3618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iritkatriel @markshannon